fix: update manual sub account odering behavior #1681
Merged
+296
−33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
✅ Heimdall Review Status
|
stephancill
force-pushed
the
stephan/manual-subaccount-ordering
branch
from
d9f686b to
29c2270
Compare
cb-jake
previously approved these changes
Jul 8, 2025
montycheese
reviewed
Jul 8, 2025
| this.accounts = subAccountsConfig?.enableAutoSubAccounts | ||
| ? prependWithoutDuplicates(this.accounts, subAccount.address) | ||
| : appendWithoutDuplicates(this.accounts, subAccount.address); | ||
| } |
Contributor
There was a problem hiding this comment.
we should have been doing this before here actually 🤔
montycheese
previously approved these changes
Jul 8, 2025
stephancill
force-pushed
the
stephan/manual-subaccount-ordering
branch
from
587a943 to
10d8e8d
Compare
stephancill
requested review from
cb-jake and
montycheese
and removed request for
cb-jake
montycheese
approved these changes
Jul 8, 2025
fan-zhang-sv
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
https://linear.app/coinbase/issue/BA-2376/sdk-update-default-sub-account-behavior
When
enableAutoSubAccountsis false, we no longer automatically make the sub account the 'active' account. All requests meant for the sub accounts need to explicitly specify the sub account address.In this mode, the sub account is always returned at index 1 when calling
eth_requestAccountsandeth_accounts.How did you test your changes?
Unit tests, manual testing in playground